Skip to content

Conversation

@gyuho
Copy link
Member

@gyuho gyuho commented Sep 17, 2025

NVML may report GSP as enabled even when it's disabled at the kernel level.
Fallback mechanism to validate the GSP firmware mode against kernel module configuration.

$ cat /etc/modprobe.d/nvidia.conf
options nvidia NVreg_EnableGpuFirmware=0

$ nvidia-smi -q | grep "GSP"
    GSP Firmware Version                  : N/A

Signed-off-by: Gyuho Lee gyuhol@nvidia.com

@gyuho gyuho added this to the v0.8.0 milestone Sep 17, 2025
@gyuho gyuho self-assigned this Sep 17, 2025
@gyuho gyuho added the wip - do not merge working in progress label Sep 17, 2025
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 72.54902% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.31%. Comparing base (70316cf) to head (702bd62).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/nvidia-query/nvml/gsp_firmware.go 70.83% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
+ Coverage   67.27%   67.31%   +0.03%     
==========================================
  Files         316      316              
  Lines       26312    26363      +51     
==========================================
+ Hits        17702    17746      +44     
- Misses       7726     7731       +5     
- Partials      884      886       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gyuho gyuho removed the wip - do not merge working in progress label Sep 18, 2025
@gyuho gyuho force-pushed the gsp-firmware-mode-fallback-using-kernel-conf-file branch from dce5bd9 to 86463a0 Compare September 18, 2025 14:59
NVML may report GSP as enabled even when it's disabled at the kernel level.
Fallback mechanism to validate the GSP firmware mode against kernel module configuration.

```
$ cat /etc/modprobe.d/nvidia.conf
options nvidia NVreg_EnableGpuFirmware=0

$ nvidia-smi -q | grep "GSP"
    GSP Firmware Version                  : N/A
```

Signed-off-by: Gyuho Lee <gyuhol@nvidia.com>
@gyuho gyuho force-pushed the gsp-firmware-mode-fallback-using-kernel-conf-file branch from 86463a0 to 702bd62 Compare September 18, 2025 14:59
@gyuho gyuho changed the title feat(nvidia/gsp-firmware-mode): fallback using kernel config file [LEP-2340] feat(nvidia/gsp-firmware-mode): fallback using kernel config file Sep 19, 2025
@gyuho gyuho added the wip - do not merge working in progress label Sep 22, 2025
@gyuho
Copy link
Member Author

gyuho commented Sep 23, 2025

Closing in favor of #1083.

@gyuho gyuho closed this Sep 23, 2025
@gyuho gyuho deleted the gsp-firmware-mode-fallback-using-kernel-conf-file branch September 23, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wip - do not merge working in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant