Skip to content

Conversation

@gyuho
Copy link
Member

@gyuho gyuho commented Sep 17, 2025

@gyuho gyuho added this to the v0.8.0 milestone Sep 17, 2025
@gyuho gyuho self-assigned this Sep 17, 2025
@gyuho gyuho force-pushed the set-healthy-via-local-api branch from 688ab9f to f0cd5f2 Compare September 17, 2025 13:36
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 28.08989% with 128 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.34%. Comparing base (fc398aa) to head (4c3a0c3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/server/handlers_components.go 10.52% 51 Missing ⚠️
cmd/gpud/set-healthy/command.go 0.00% 41 Missing ⚠️
cmd/gpud/command/command.go 0.00% 17 Missing ⚠️
pkg/server/handlers.go 7.14% 13 Missing ⚠️
client/v1/v1_set_healthy.go 87.75% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
- Coverage   67.65%   67.34%   -0.31%     
==========================================
  Files         313      315       +2     
  Lines       26081    26254     +173     
==========================================
+ Hits        17644    17680      +36     
- Misses       7558     7691     +133     
- Partials      879      883       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@MaxFedotov MaxFedotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @gyuho! That's what we really need

> curl -s -kL https://localhost:15132/v1/health-states/set-healthy?components=accelerator-nvidia-error-xid

Signed-off-by: Gyuho Lee <gyuhol@nvidia.com>
@gyuho gyuho force-pushed the set-healthy-via-local-api branch from 837b0ad to a63d816 Compare September 17, 2025 23:20
@gyuho gyuho changed the title feat(server): add set healthy states local API endpoint feat(server,cmd): add set healthy states local API endpoint, add "gpud set-healthy" command Sep 18, 2025
Signed-off-by: Gyuho Lee <gyuhol@nvidia.com>
Signed-off-by: Gyuho Lee <gyuhol@nvidia.com>
Signed-off-by: Gyuho Lee <gyuhol@nvidia.com>
Signed-off-by: Gyuho Lee <gyuhol@nvidia.com>
@gyuho gyuho merged commit 70316cf into main Sep 18, 2025
10 of 12 checks passed
@gyuho gyuho deleted the set-healthy-via-local-api branch September 18, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants