feat: refactor dockerfile and expose additional helm chart variables #1068
Conversation
MaxFedotov
force-pushed
the
issues/1067
branch
from
14e47d7 to
6c0e362
Compare
MaxFedotov
force-pushed
the
issues/1067
branch
from
6c0e362 to
a186e65
Compare
|
We will take a look! /cc @pteranodan |
| COPY api/ api/ | ||
| COPY client/ client/ | ||
| COPY cmd/ cmd/ | ||
| COPY components/ components/ | ||
| COPY docs/ docs/ | ||
| COPY pkg/ pkg/ | ||
| COPY version/ version/ | ||
| COPY Makefile Makefile |
There was a problem hiding this comment.
Thoughts on simplifying this to a single COPY . . command and managing exclusions in a .dockerignore file?
There was a problem hiding this comment.
The only thing that worries me with adding them to .dockerignore is that we are abstracting some build details from the Dockerfile and that can make troubleshooting a bit harder. It is much easier when everything is in the single file, even if this makes it a bit bigger
There was a problem hiding this comment.
Fair point. The main reason I suggested the COPY . . command together with a .dockerignore file, is that this pattern is recommended by Docker. It avoids having to update the Dockerfile when new directories are added, it prevents sensitive or unnecessary files from ever being sent to the Docker daemon (keeping the build context small and is a crucial security best practice), and makes exclusions explicit.
/cc @gyuho
|
@MaxFedotov Thanks for the contribution. We have many others that look to support GPUd in container mode. Please let us know how it goes, or feel free to email us at gyuhol@nvidia.com! |
3 participants
fixes #1067