Skip to content

Conversation

@lemire
Copy link
Owner

@lemire lemire commented Oct 15, 2025

Repackage with uv and use pyproject.toml.

@lemire lemire requested a review from Copilot October 15, 2025 20:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Repackage build and distribution to use pyproject.toml and uv, simplify setup.py for C extension, and inline cibuildwheel configuration in pyproject and CI.

  • Move project metadata to pyproject.toml; keep a minimal setup.py for C extension compatibility
  • Update README with uv-based install/build instructions
  • Update GitHub Actions: use uv for sdist, read cibuildwheel config from pyproject, and upload to PyPI only on tags

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
setup.py Replace full setup with a minimal ext_modules-only config; metadata lives in pyproject
pyproject.toml Add PEP 621 metadata and inline cibuildwheel configuration
pyproject-cibuildwheel.toml Remove now-redundant cibuildwheel config file
README.md Document uv install/build workflows and modern build-from-source steps
.github/workflows/buildwheels.yml Use uv to build sdist and rely on pyproject-based cibuildwheel config; restrict PyPI uploads to tags

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cjauvin and others added 6 commits October 15, 2025 18:43
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@cjauvin
Copy link
Collaborator

cjauvin commented Oct 15, 2025

@lemire the updates suggested by Copilot's PR are crap btw

@lemire
Copy link
Owner Author

lemire commented Oct 16, 2025

@cjauvin

the updates suggested by Copilot's PR are crap btw

Maybe the AI is messing with you. 🤖

@lemire
Copy link
Owner Author

lemire commented Oct 16, 2025

Let us merge this and hope for the best.

Thanks @cjauvin

@lemire lemire merged commit 8c40afa into master Oct 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants