-
Notifications
You must be signed in to change notification settings - Fork 15
Repackage with uv #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Repackage build and distribution to use pyproject.toml and uv, simplify setup.py for C extension, and inline cibuildwheel configuration in pyproject and CI.
- Move project metadata to pyproject.toml; keep a minimal setup.py for C extension compatibility
- Update README with uv-based install/build instructions
- Update GitHub Actions: use uv for sdist, read cibuildwheel config from pyproject, and upload to PyPI only on tags
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Replace full setup with a minimal ext_modules-only config; metadata lives in pyproject |
| pyproject.toml | Add PEP 621 metadata and inline cibuildwheel configuration |
| pyproject-cibuildwheel.toml | Remove now-redundant cibuildwheel config file |
| README.md | Document uv install/build workflows and modern build-from-source steps |
| .github/workflows/buildwheels.yml | Use uv to build sdist and rely on pyproject-based cibuildwheel config; restrict PyPI uploads to tags |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@lemire the updates suggested by Copilot's PR are crap btw |
Maybe the AI is messing with you. 🤖 |
|
Let us merge this and hope for the best. Thanks @cjauvin |
Repackage with uv and use
pyproject.toml.