Make test_averaging_cancel more robust #650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
test_averaging_cancel
is one of the few flaky tests in our codebase: see e.g. https://github.com/learning-at-home/hivemind/actions/runs/14024261668/job/40777059821, where it failed 3 times out of 5.Based on my investigation and discussion with @justheuristic, it looks like the problem is that it's very loosely defined: we start 4 averaging peers, cancel 2, and expect that the group size is 2 nonetheless. However, due to
target_group_size=None
by default, it's possible for the groups to have sizes of 3 and 1, which means that thelen(control.result()) == 2
will occasionally fail.To fix this issue, the PR introduces a separate test case with a fixed
target_group_size
. To make sure that peers don't average before cancellation, it also uses the averaging triggers to arrange the groups without starting the averaging itself