Skip to content

Fix version-file for the Ruff action #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2025
Merged

Fix version-file for the Ruff action #649

merged 4 commits into from
Apr 19, 2025

Conversation

mryab
Copy link
Member

@mryab mryab commented Apr 19, 2025

ruff-action parses the version of Ruff from the specified dependency version: https://github.com/astral-sh/ruff-action/blob/main/src/utils/pyproject.ts#L26

As we specify our dependencies in pyproject.toml, the parsing fails. This PR fixes the issue by pointing the action at pyproject.toml instead

@mryab mryab merged commit 518a56f into master Apr 19, 2025
14 of 17 checks passed
@mryab mryab deleted the fix-ruff branch April 19, 2025 09:30
Copy link

codecov bot commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (d20e810) to head (01adf5a).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
- Coverage   85.39%   85.38%   -0.02%     
==========================================
  Files          81       96      +15     
  Lines        8006     8575     +569     
==========================================
+ Hits         6837     7322     +485     
- Misses       1169     1253      +84     

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mryab added a commit that referenced this pull request Apr 20, 2025
* Fix version-file for the Ruff action

* Fix the format

(cherry picked from commit 518a56f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant