Skip to content

Enable GitHub Actions for tests #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2025
Merged

Enable GitHub Actions for tests #644

merged 2 commits into from
Mar 15, 2025

Conversation

mryab
Copy link
Member

@mryab mryab commented Mar 15, 2025

Modal tests do not run in forked repositories, because they require access to secrets. As a different measure, we'll enable tests both via Modal and GHA to ensure that pull requests from external contributors can still be tested

@mryab mryab requested review from justheuristic and dvmazur March 15, 2025 12:30
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (d20e810) to head (b2da566).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
+ Coverage   85.39%   86.16%   +0.76%     
==========================================
  Files          81       96      +15     
  Lines        8006     8584     +578     
==========================================
+ Hits         6837     7396     +559     
- Misses       1169     1188      +19     

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mryab mryab merged commit da2c465 into master Mar 15, 2025
41 of 53 checks passed
@mryab mryab deleted the run-gha-from-fork branch March 15, 2025 14:34
mryab added a commit that referenced this pull request Apr 20, 2025
* Enable GitHub Actions for tests

* Skip GHA tests if called from the root repo

(cherry picked from commit da2c465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants