Add multiaddr as subpackage #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mryab
force-pushed
the
multiaddr-subpackage
branch
from
5b29f81 to
a106157
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 85.39% 86.23% +0.83%
==========================================
Files 81 96 +15
Lines 8006 8584 +578
==========================================
+ Hits 6837 7402 +565
- Misses 1169 1182 +13
🚀 New features to boost your workflow:
|
mryab
approved these changes
Mar 15, 2025
mryab
added a commit
that referenced
this pull request
Apr 20, 2025
* Add multiaddr as subpackage * Remove py-multiaddr dependency * Move to hivemind.utils, add copyright notices * Add multiaddr tests * Add newline in requirements.txt --------- Co-authored-by: Max Ryabinin <mryabinin0@gmail.com> (cherry picked from commit 02ddf5c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use a version of multiaddr from a specific commit https://github.com/learning-at-home/hivemind/blob/master/requirements.txt#L13 because we require multiformats/py-multiaddr#63 (py-multiaddr is no longer maintained, so there is no up-to-date version of it in PyPI). However, this prevents us from publishing the new release of Hivemind:
This PR vendors py-multiaddr into hivemind, removing our dependency on this commit from an external repository