fix: repair many examples in manual to run in isolation #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreedcmu
force-pushed
the
jcreed-live-link-fixes
branch
from
665271c to
7decc1b
Compare
Fix all reference manual example to be self-contained for the purpose of https://live.lean-lang.org links.
jcreedcmu
force-pushed
the
jcreed-live-link-fixes
branch
from
7decc1b to
5f6d227
Compare
|
Preview for this PR is ready! 🎉 (also as a proofreading version). built with commit 5f6d227. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few dozen
:::exampledirectives in the manual that won't run correctly if you copy and paste them into https://live.lean-lang.org/ . Fix them all, and include a CI check to ensure that they are all fixes. A sampling of reasons include:#check_declis defined in reference manual but not available in liveimports ofLeanorStdare missingopens prior to the:::exampleare necessary+errorblocks and needed to be hoistedBased on top of #609 .
Progress towards leanprover/verso#569 .