Skip to content

refactor: update and consolidate attribute-related error messages #9495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 26, 2025

Conversation

jrr6
Copy link
Contributor

@jrr6 jrr6 commented Jul 23, 2025

This PR consolidates common attribute-related error messages into reusable functions and updates the wording and formatting of relevant error messages.

@jrr6 jrr6 added the changelog-no Do not include this PR in the release changelog label Jul 23, 2025
@jrr6 jrr6 force-pushed the attribute-error-refactor branch from d0059f7 to 2fe3a63 Compare July 24, 2025 00:40
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 24, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jul 24, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9d93b10919ba21cbc2855b73d2d2302567bb9fd8 --onto cdab726e3d289b80860ae9f5a7de21d990c8b95f. You can force Mathlib CI using the force-mathlib-ci label. (2025-07-24 01:23:50)
  • 💥 Mathlib branch lean-pr-testing-9495 build failed against this PR. (2025-07-24 18:44:18) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase bc5526cacbe4fdea27b273517fb364fcd24eb8e0 --onto 73422d52fd61c3d5bce6f5edb53c6bd698b1b7ba. You can force Mathlib CI using the force-mathlib-ci label. (2025-07-25 19:01:24)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Jul 24, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 9d93b10919ba21cbc2855b73d2d2302567bb9fd8 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-07-24 01:23:51)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-07-23 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-07-24 18:00:31)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase bc5526cacbe4fdea27b273517fb364fcd24eb8e0 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-07-25 19:01:26)

@jrr6 jrr6 force-pushed the attribute-error-refactor branch from 2fe3a63 to 2d0479a Compare July 24, 2025 17:18
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jul 24, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jul 24, 2025
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jul 24, 2025
@jrr6 jrr6 marked this pull request as ready for review July 25, 2025 18:06
@jrr6 jrr6 added this pull request to the merge queue Jul 26, 2025
Merged via the queue into leanprover:master with commit fcbd103 Jul 26, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants