fix: let simp apply autogenerated congruence theorems #9493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies `mkCongrSimp?` to take the number of arguments in an application into account when generating congruence lemmas. This fixes an issue where partially applied functions with proof/subsingleton dependencies were not being simplified. Closes leanprover#2128 This does not yet help `simp` handle over-applied functions.
github-actions
bot
added
the
toolchain-available
|
Reference manual CI status:
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 23, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 23, 2025
leanprover-community-bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
builds-mathlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a
simpissue where arguments to partially-applied functions that were depended-upon by proof/subsingleton arguments were not being simplified. In particular, the congruence lemma generatormkCongrSimp?did not take into account the number of arguments in an application, instead assuming all functions were fully applied.Closes #2128
Implementation note: now the congruence lemma cache is keyed by the expected arity as well.
Mathlib note: the only breakage is a handful of
simp_rws that started to loop because this PR unlocked some rewrites. They were using rules of the formx = f x, so the remediation was to either userwor to add the+singlePassoption.The PR doesn't address congruence lemmas for overapplied functions.