[Merged by Bors] - chore: remove redundant fields from instances #30734
+44
−262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JovanGerb
added
the
bench-after-CI
PR summary dde1cfffb6Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
!bench |
|
Here are the benchmark results for commit 523815b. Benchmark Metric Change
===========================================================================
+ ~Mathlib.Analysis.Distribution.SchwartzSpace instructions -4.6%
+ ~Mathlib.Analysis.Fourier.FourierTransformDeriv instructions -4.7%
+ ~Mathlib.Combinatorics.SimpleGraph.Regularity.Chunk instructions -9.4%
+ ~Mathlib.Computability.AkraBazzi.GrowsPolynomially instructions -13.1%
+ ~Mathlib.Computability.AkraBazzi.SumTransform instructions -11.3%
+ ~Mathlib.Geometry.Manifold.VectorBundle.Riemannian instructions -6.6%
+ ~Mathlib.RingTheory.Extension.Cotangent.Basic instructions -5.6%
+ ~Mathlib.RingTheory.Kaehler.JacobiZariski instructions -12.1%
+ ~Mathlib.RingTheory.Kaehler.Polynomial instructions -7.0%
+ ~Mathlib.Topology.VectorBundle.Riemannian instructions -5.8% |
150 files, Instructions -2.0⬝10⁹
47 files, Instructions -3.0⬝10⁹
25 files, Instructions -4.0⬝10⁹
8 files, Instructions -5.0⬝10⁹
8 files, Instructions -6.0⬝10⁹
6 files, Instructions -7.0⬝10⁹
2 files, Instructions -8.0⬝10⁹
2 files, Instructions -9.0⬝10⁹
2 files, Instructions -10.0⬝10⁹
4 files, Instructions -11.0⬝10⁹
3 files, Instructions -12.0⬝10⁹
|
github-actions
bot
removed
the
bench-after-CI
|
The +44 lines is misleading -- this is doing essentially nothing other than deleting code (and then occasionally moving brackets to confuse github). The only changes not of this form are a couple of changes of |
|
Thanks 🎉 bors merge |
leanprover-community-mathlib4-bot
added
the
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
This PR removes all occurrences of patterns like `mul := (· * ·)` in definitions of instances. These patterns are unneccessary, and sometimes they cause the instance to behave inefficiently during unification. I have no idea why these patterns were there in the first place. Maybe it was a Lean3 thing? As a result, we get a pretty good speedup: 0.63% less instructions.
|
Build failed: |
|
bors r- bors d+ |
|
✌️ JovanGerb can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
|
bors r+ |
leanprover-community-mathlib4-bot
added
the
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
This PR removes all occurrences of patterns like `mul := (· * ·)` in definitions of instances. These patterns are unneccessary, and sometimes they cause the instance to behave inefficiently during unification. I have no idea why these patterns were there in the first place. Maybe it was a Lean3 thing? As a result, we get a pretty good speedup: 0.63% less instructions.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
|
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all occurrences of patterns like
mul := (· * ·)in definitions of instances. These patterns are unneccessary, and sometimes they cause the instance to behave inefficiently during unification.I have no idea why these patterns were there in the first place. Maybe it was a Lean3 thing?
As a result, we get a pretty good speedup: 0.63% less instructions.