Skip to content

Conversation

JovanGerb
Copy link
Collaborator

This PR defines the by_cases! h : p tactic, which is a macro for by_cases h : p followed by a try push_neg at h in the second goal. We use try push_neg instead of push_neg to make the tactic also succeed when no negation is pushed. Should there maybe be an optional linter telling you to use by_cases instead if possible?


Open in Gitpod

@github-actions github-actions bot added the t-meta Tactics, attributes or user commands label Oct 20, 2025
Copy link

github-actions bot commented Oct 20, 2025

PR summary dde1cfffb6

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Tactic 2877 2879 +2 (+0.07%)
Import changes for all files
Files Import difference
Mathlib.Tactic 2
Mathlib.Tactic.ByCases (new file) 77

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant