Skip to content

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Oct 19, 2025

Add instances that the supremum of two affine subspaces, either one nonempty, is nonempty. These are useful when working with orthogonal projections onto such a supremum.


Open in Gitpod

Add instances that the supremum of two affine subspaces, either one
nonempty, is nonempty.  These are useful when working with orthogonal projections onto such a supremum.
@jsm28 jsm28 added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Oct 19, 2025
Copy link

github-actions bot commented Oct 19, 2025

PR summary 39996ca4db

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ nonempty_sup_left
+ nonempty_sup_right

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser
Copy link
Member

!bench

@eric-wieser eric-wieser added the awaiting-bench This PR needs to be benchmarked before merging label Oct 19, 2025
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 9ddca9d.Found no runs to compare against.

@eric-wieser
Copy link
Member

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 9ddca9d.Found no runs to compare against.

@eric-wieser
Copy link
Member

Could you merge master to see if that fixes this?

@eric-wieser
Copy link
Member

!bench

@eric-wieser
Copy link
Member

To be clear, I've seen people worry about the performance of Nonempty instances in the past, especially when applied to terms that aren't direct applications of type families, and wanted to check that the is no issue here.

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 365b6a2.
There were no significant changes against commit 39996ca.

Copy link

File Instructions %
build +6.435⬝10⁹ (+0.00%)
CI run Lakeprof report

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

mathlib-bors bot pushed a commit that referenced this pull request Oct 20, 2025
…0699)

Add instances that the supremum of two affine subspaces, either one nonempty, is nonempty.  These are useful when working with orthogonal projections onto such a supremum.
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 20, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 20, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(LinearAlgebra/AffineSpace/AffineSubspace/Defs): nonempty sup [Merged by Bors] - feat(LinearAlgebra/AffineSpace/AffineSubspace/Defs): nonempty sup Oct 20, 2025
@mathlib-bors mathlib-bors bot closed this Oct 20, 2025
@jsm28 jsm28 deleted the AffineSubspace_nonempty_sup branch October 20, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-bench This PR needs to be benchmarked before merging easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants