-
Notifications
You must be signed in to change notification settings - Fork 839
[Merged by Bors] - feat(LinearAlgebra/AffineSpace/AffineSubspace/Defs): nonempty sup #30699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(LinearAlgebra/AffineSpace/AffineSubspace/Defs): nonempty sup #30699
Conversation
Add instances that the supremum of two affine subspaces, either one nonempty, is nonempty. These are useful when working with orthogonal projections onto such a supremum.
PR summary 39996ca4dbImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
!bench |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Here are the benchmark results for commit 9ddca9d.Found no runs to compare against. |
!bench |
Here are the benchmark results for commit 9ddca9d.Found no runs to compare against. |
Could you merge master to see if that fixes this? |
!bench |
To be clear, I've seen people worry about the performance of |
Here are the benchmark results for commit 365b6a2. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Thanks!
…0699) Add instances that the supremum of two affine subspaces, either one nonempty, is nonempty. These are useful when working with orthogonal projections onto such a supremum.
Pull request successfully merged into master. Build succeeded: |
Add instances that the supremum of two affine subspaces, either one nonempty, is nonempty. These are useful when working with orthogonal projections onto such a supremum.