Skip to content

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented Oct 17, 2025

An argument W' is incorrectly implicit in WeierstrassCurve.Affine.CoordinateRing and WeierstrassCurve.Affine.FunctionField. This issue has not surfaced because the dot notation (W'.CoordinateRing) is always used.


Open in Gitpod

@github-actions github-actions bot added the t-algebraic-geometry Algebraic geometry label Oct 17, 2025
Copy link

github-actions bot commented Oct 17, 2025

PR summary 2528a23415

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Komyyy Komyyy added the easy < 20s of review time. See the lifecycle page for guidelines. label Oct 17, 2025
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 17, 2025
@Komyyy Komyyy removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 17, 2025
@joelriou
Copy link
Collaborator

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 18, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 18, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 18, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(AlgebraicGeometry) : an argument is incorrectly explicit [Merged by Bors] - refactor(AlgebraicGeometry) : an argument is incorrectly explicit Oct 18, 2025
@mathlib-bors mathlib-bors bot closed this Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants