Skip to content

Conversation

harahu
Copy link
Contributor

@harahu harahu commented Oct 16, 2025

Found with the help of Codex.


Open in Gitpod

@github-actions github-actions bot added the t-combinatorics Combinatorics label Oct 16, 2025
Copy link

github-actions bot commented Oct 16, 2025

PR summary 4e56e21745

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Collaborator

grunweg commented Oct 16, 2025

Thanks for your PR. Can you fix the build, please?

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 16, 2025
@harahu
Copy link
Contributor Author

harahu commented Oct 17, 2025

Done 👍

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 17, 2025
@grunweg
Copy link
Collaborator

grunweg commented Oct 17, 2025

Thanks!
bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 17, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 17, 2025
Found with the help of Codex.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 17, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc(Combinatorics): fix typos [Merged by Bors] - doc(Combinatorics): fix typos Oct 17, 2025
@mathlib-bors mathlib-bors bot closed this Oct 17, 2025
@harahu harahu deleted the doc/com branch October 17, 2025 11:02
@harahu
Copy link
Contributor Author

harahu commented Oct 17, 2025

Btw, @grunweg, I think it was a wise call of you to just drop the part of this PR you were unconvinced by in order to facilitate a speedy merge. If you encounter similar cases again, please know that I'm very comfortable with you trimming down the PR without my permission. It is trivial for me to create a separate PR from history, should I want to.

@grunweg
Copy link
Collaborator

grunweg commented Oct 17, 2025

Thanks; it's good to hear this is fine. (I was slightly hesitant.)

If you really think this is a typo (and you might be perfectly fine!), please create a separate PR. That's just not a PR I'm feeling comfortable to merge, and letting 19 typo fixes grow stale because of that one seemed to be not the trade-off we want.

YaelDillies pushed a commit to YaelDillies/mathlib4 that referenced this pull request Oct 17, 2025
Found with the help of Codex.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants