-
Notifications
You must be signed in to change notification settings - Fork 840
[Merged by Bors] - doc(Combinatorics): fix typos #30621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary 4e56e21745Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
Thanks for your PR. Can you fix the build, please? |
Done 👍 -awaiting-author |
Thanks! |
Found with the help of Codex. Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Pull request successfully merged into master. Build succeeded: |
Btw, @grunweg, I think it was a wise call of you to just drop the part of this PR you were unconvinced by in order to facilitate a speedy merge. If you encounter similar cases again, please know that I'm very comfortable with you trimming down the PR without my permission. It is trivial for me to create a separate PR from history, should I want to. |
Thanks; it's good to hear this is fine. (I was slightly hesitant.) If you really think this is a typo (and you might be perfectly fine!), please create a separate PR. That's just not a PR I'm feeling comfortable to merge, and letting 19 typo fixes grow stale because of that one seemed to be not the trade-off we want. |
Found with the help of Codex. Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Found with the help of Codex.