Skip to content

Conversation

winstonyin
Copy link
Collaborator

@winstonyin winstonyin commented Oct 16, 2025

Make them match the naming convention, as discussed on zulip: #mathlib4 > Naming convention @ 💬


Open in Gitpod

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Oct 16, 2025
Copy link

PR summary c092d56cb7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Collaborator

grunweg commented Oct 16, 2025

Thanks for doing this. Looks very good. I'll wait for CI to finish, then bors merge it.

@grunweg
Copy link
Collaborator

grunweg commented Oct 16, 2025

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 16, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 16, 2025
Make them match the naming convention, as discussed on zulip: [#mathlib4 > Naming convention @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Naming.20convention/near/545300205)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 16, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: rename fields in ImplicitFunctionData [Merged by Bors] - chore: rename fields in ImplicitFunctionData Oct 16, 2025
@mathlib-bors mathlib-bors bot closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants