Skip to content

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 14, 2025


Open in Gitpod

Copy link

PR summary 7a9e177031

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg self-assigned this Oct 14, 2025
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice golfs, thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@YaelDillies
Copy link
Collaborator

Have you seen #30508 ?

@grunweg
Copy link
Collaborator

grunweg commented Oct 15, 2025

I didn't; since this PR builds but #30508 doesn't, shall we merge this one first?

@grunweg
Copy link
Collaborator

grunweg commented Oct 15, 2025

(I can try to take a look at #30508 next.)

@YaelDillies
Copy link
Collaborator

I believe the intersection of both PRs is very small (but non-empty). It's probably fine to merge this one first

@riccardobrasca
Copy link
Member

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit d238bcf.
There were no significant changes against commit 7a9e177.

Copy link

File Instructions %
build +7.418⬝10⁹ (+0.00%)
Mathlib.Probability.StrongLaw +1.988⬝10⁹ (+2.54%)
CI run Lakeprof report

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels Oct 15, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 15, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(*): use gcongr/grw [Merged by Bors] - chore(*): use gcongr/grw Oct 15, 2025
@mathlib-bors mathlib-bors bot closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants