-
Notifications
You must be signed in to change notification settings - Fork 839
[Merged by Bors] - feat(Algebra/Order/Module): add missing instances #30544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary e568f0d0bc
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Algebra.Order.Module.Defs | 477 | 478 | +1 (+0.21%) |
Import changes for all files
Files | Import difference |
---|---|
8 filesMathlib.Algebra.Order.Module.Basic Mathlib.Algebra.Order.Module.Defs Mathlib.Algebra.Order.Module.Field Mathlib.Algebra.Order.Monovary Mathlib.Algebra.Order.Nonneg.Module Mathlib.Algebra.QuadraticDiscriminant Mathlib.Tactic.LinearCombination.Lemmas Mathlib.Tactic.LinearCombination |
1 |
Declarations diff
+ instPosSMulMono
+ instPosSMulReflectLE
+ instPosSMulStrictMono
+ instSMulPosMono
+ instSMulPosReflectLE
+ instSMulPosReflectLT
+ instSMulPosStrictMono
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
!bench |
Here are the benchmark results for commit 5e759f6. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
maintainer delegate
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Thanks! bors d+ |
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
As this PR is labelled bors merge |
As this PR is labelled bors merge |
Already running a review |
As this PR is labelled bors merge |
Already running a review |
Pull request successfully merged into master. Build succeeded: |
Currently, it adds an import to
Defs
. Another option is to move theProd
andPi
instances toBasic.lean
.