Skip to content

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 14, 2025


Currently, it adds an import to Defs. Another option is to move the Prod and Pi instances to Basic.lean.

Open in Gitpod

@urkud urkud added the bench-after-CI Once the PR passes CI, comment `!bench` on the PR label Oct 14, 2025
@urkud urkud requested a review from YaelDillies October 14, 2025 12:06
Copy link

github-actions bot commented Oct 14, 2025

PR summary e568f0d0bc

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Order.Module.Defs 477 478 +1 (+0.21%)
Import changes for all files
Files Import difference
8 files Mathlib.Algebra.Order.Module.Basic Mathlib.Algebra.Order.Module.Defs Mathlib.Algebra.Order.Module.Field Mathlib.Algebra.Order.Monovary Mathlib.Algebra.Order.Nonneg.Module Mathlib.Algebra.QuadraticDiscriminant Mathlib.Tactic.LinearCombination.Lemmas Mathlib.Tactic.LinearCombination
1

Declarations diff

+ instPosSMulMono
+ instPosSMulReflectLE
+ instPosSMulStrictMono
+ instSMulPosMono
+ instSMulPosReflectLE
+ instSMulPosReflectLT
+ instSMulPosStrictMono

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 14, 2025
@leanprover-community-mathlib4-bot
Copy link
Collaborator

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 5e759f6.
There were no significant changes against commit ac33158.

Copy link

File Instructions %
build -6.813⬝10⁹ (+0.00%)
lint -1.208⬝10⁹ (-0.01%)
Mathlib.Algebra.Order.Module.Defs +2.896⬝10⁹ (+5.12%)
CI run Lakeprof report

@github-actions github-actions bot removed the bench-after-CI Once the PR passes CI, comment `!bench` on the PR label Oct 14, 2025
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 18, 2025

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@urkud urkud added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Oct 18, 2025
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 18, 2025
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 18, 2025

Already running a review

@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 18, 2025

Already running a review

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 18, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Order/Module): add missing instances [Merged by Bors] - feat(Algebra/Order/Module): add missing instances Oct 18, 2025
@mathlib-bors mathlib-bors bot closed this Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants