Skip to content

Conversation

vasnesterov
Copy link
Collaborator

@vasnesterov vasnesterov commented Oct 13, 2025

When the order tactic fails, it prints all the types it was run on. The order in which these types are printed is arbitrary, and any changes in the transitive imports of order.lean can change this order and cause the test to fail.

For example #mathlib4 > MathlibTest.order error

This PR removes the second type from the test.


Open in Gitpod

Copy link

PR summary 7a9e177031

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vasnesterov vasnesterov added bug Something isn't working t-meta Tactics, attributes or user commands easy < 20s of review time. See the lifecycle page for guidelines. labels Oct 13, 2025
@b-mehta
Copy link
Contributor

b-mehta commented Oct 14, 2025

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 14, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 14, 2025
When the `order` tactic fails, it prints all the types it was run on. The order in which these types are printed is arbitrary, and any changes in the transitive imports of `order.lean` can change this order and cause the test to fail.

For example [#mathlib4 > MathlibTest.order error](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/MathlibTest.2Eorder.20error/with/544585480)

This PR removes the second type from the test.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: remove second type from test in order.lean [Merged by Bors] - fix: remove second type from test in order.lean Oct 14, 2025
@mathlib-bors mathlib-bors bot closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants