[Merged by Bors] - chore: move Data/Real/GoldenRatio and RingTheory/Real/Irrational to NumberTheory/Real #30498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary b2a9ee2917Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
note: file note: file |
github-actions
bot
added
the
file-removed
YaelDillies
reviewed
Oct 13, 2025
I like this solution! |
grunweg
changed the title
|
Good idea, implemented. |
Ruben-VandeVelde
approved these changes
Oct 15, 2025
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
|
Thanks! bors merge |
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…umberTheory/Real (#30498) Neither file is about data structures, so let's find a better home for them. Create a new directory `NumberTheory/Real` for them. Moving these files was suggested [on zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Cleaning.20up.20.60Data.60/with/544442456).
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…umberTheory/Real (#30498) Neither file is about data structures, so let's find a better home for them. Create a new directory `NumberTheory/Real` for them. Moving these files was suggested [on zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Cleaning.20up.20.60Data.60/with/544442456).
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…umberTheory/Real (#30498) Neither file is about data structures, so let's find a better home for them. Create a new directory `NumberTheory/Real` for them. Moving these files was suggested [on zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Cleaning.20up.20.60Data.60/with/544442456).
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…umberTheory/Real (#30498) Neither file is about data structures, so let's find a better home for them. Create a new directory `NumberTheory/Real` for them. Moving these files was suggested [on zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Cleaning.20up.20.60Data.60/with/544442456).
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…umberTheory/Real (#30498) Neither file is about data structures, so let's find a better home for them. Create a new directory `NumberTheory/Real` for them. Moving these files was suggested [on zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Cleaning.20up.20.60Data.60/with/544442456).
|
Build failed: |
|
Please merge |
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Thanks for the reminder; one file needed a fix. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…umberTheory/Real (#30498) Neither file is about data structures, so let's find a better home for them. Create a new directory `NumberTheory/Real` for them. Moving these files was suggested [on zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Cleaning.20up.20.60Data.60/with/544442456).
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither file is about data structures, so let's find a better home for them.
Create a new directory
NumberTheory/Realfor them. Moving these files was suggested on zulip.