Skip to content

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Oct 13, 2025

This file as added in #29513, but never hooked up to the unit tests. It is thus unused; delete it.


Open in Gitpod

This file as added in leanprover-community#29513, but never hooked up to the unit tests.
It is thus unused; delete it.
@grunweg grunweg requested a review from adomani October 13, 2025 08:35
@grunweg grunweg added the easy < 20s of review time. See the lifecycle page for guidelines. label Oct 13, 2025
Copy link

PR summary 4e9ce78ebd

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

note: file MathlibTest/LintStyle2.lean was removed.
Please create a follow-up pull request adding a module deprecation. Thanks!

@github-actions github-actions bot added the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label Oct 13, 2025
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 13, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 13, 2025
This file as added in #29513, but never hooked up to the unit tests. It is thus unused; delete it.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 13, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: delete unused test file [Merged by Bors] - chore: delete unused test file Oct 13, 2025
@mathlib-bors mathlib-bors bot closed this Oct 13, 2025
@grunweg grunweg deleted the delete-superfluous branch October 13, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. file-removed A Lean module was (re)moved without a `deprecated_module` annotation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants