Skip to content

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented Oct 11, 2025

For consistency with eq_zero_of_zpow_eq_zero.


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 11, 2025
Copy link

github-actions bot commented Oct 11, 2025

PR summary b1b0f15515

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ eq_zero_of_pow_eq_zero

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies
Copy link
Collaborator

pow_eq_zero is the misnamed one here!

@Ruben-VandeVelde Ruben-VandeVelde changed the title chore: rename eq_zero_of_zpow_eq_zero to zpow_eq_zero chore: rename pow_eq_zero to eq_zero_of_pow_eq_zero Oct 14, 2025
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@sgouezel
Copy link
Contributor

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 15, 2025

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Ruben-VandeVelde
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Oct 16, 2025
For consistency with eq_zero_of_zpow_eq_zero.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 16, 2025

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Oct 16, 2025
For consistency with eq_zero_of_zpow_eq_zero.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 16, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: rename pow_eq_zero to eq_zero_of_pow_eq_zero [Merged by Bors] - chore: rename pow_eq_zero to eq_zero_of_pow_eq_zero Oct 16, 2025
@mathlib-bors mathlib-bors bot closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants