-
Notifications
You must be signed in to change notification settings - Fork 839
[Merged by Bors] - feat(Analysis): PathConnectedSpace ℂˣ #30418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
erdOne
commented
Oct 10, 2025
PR summary 1f85fdff73Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
f13caa4
to
18823bb
Compare
Co-authored-by: Aaron Liu <aaronliu2008@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
Rectangle z w ⊆ U := by | ||
simpa only [rectangle_eq_convexHull] using convexHull_min (by grind) U_convex | ||
|
||
instance : PathConnectedSpace ℂˣ := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment explaining that this could be proved faster using other means (e.g., via the exponential map, or via facts about real vector spaces of dimension exceeding one), but that this approach was adopted to minimize imports.
✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with |
I think this proof can be golfed using |
Yes but it requires a lot more import. But this is a valid point and is also what Jireh has suggested. |
Sorry, I didn't read @j-loreaux 's comments, please forget. |
bors merge |
Pull request successfully merged into master. Build succeeded: |