Skip to content

Conversation

j-loreaux
Copy link
Collaborator


Open in Gitpod

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Oct 7, 2025
Copy link

github-actions bot commented Oct 7, 2025

PR summary 7e091d1f76

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Analysis.SpecialFunctions.ContinuousFunctionalCalculus.Abs (new file) 2240

Declarations diff

+ Commute.star_left
+ Commute.star_right
+ _root_.Commute.cfcAbs_cfcAbs
+ _root_.Commute.cfcAbs_left
+ _root_.Commute.cfcAbs_mul_eq
+ _root_.Commute.cfcAbs_right
+ _root_.cfc_comp_norm
+ _root_.cfcₙ_comp_norm
+ _root_.cfcₙ_norm_nonneg
+ _root_.cfcₙ_norm_sq_nonneg
+ abs
+ abs_add_self
+ abs_algebraMap
+ abs_algebraMap_nnreal
+ abs_eq_cfc_norm
+ abs_eq_cfcₙ_coe_norm
+ abs_eq_cfcₙ_norm
+ abs_eq_zero_iff
+ abs_intCast
+ abs_mul_abs
+ abs_mul_self
+ abs_natCast
+ abs_neg
+ abs_nnrpow
+ abs_nnrpow_two
+ abs_nnrpow_two_mul
+ abs_nonneg
+ abs_ofNat
+ abs_of_nonneg
+ abs_of_nonpos
+ abs_one
+ abs_smul
+ abs_smul_nonneg
+ abs_sq
+ abs_star
+ abs_sub_self
+ abs_zero
+ cfcAbs_cfcAbs
+ commute_abs_self
+ norm_abs
+ posPart_add_negPart
+ quasispectrum_abs
+ spectrum_abs

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@dupuisf dupuisf self-assigned this Oct 8, 2025
@themathqueen
Copy link
Collaborator

themathqueen commented Oct 8, 2025

How about also adding that abs a commutes with a for IsSelfAdjoint a?

Also, maybe that the spectrum of abs a is equal to the absolute value of the spectrum of a for IsSelfAdjoint a?

j-loreaux and others added 10 commits October 9, 2025 12:09
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@j-loreaux
Copy link
Collaborator Author

@dupuisf see my response above. Come to think of it though, I do wonder the following. Which do think is better for (almost) the entire file: CFC.***abs*** or _root_.***cfcAbs***?

@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Oct 18, 2025
@dupuisf
Copy link
Contributor

dupuisf commented Oct 19, 2025

I wasn't aware that this namespacing trick works, but I think it still looks strange... I would vote for Commute.cfcAbs_foobar and so on.

@dupuisf
Copy link
Contributor

dupuisf commented Oct 21, 2025

Looks good, thanks!

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 21, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: define CFC.abs, the absolute value in a C⋆-algebra [Merged by Bors] - feat: define CFC.abs, the absolute value in a C⋆-algebra Oct 21, 2025
@mathlib-bors mathlib-bors bot closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants