-
Notifications
You must be signed in to change notification settings - Fork 839
feat(Algebra/Polynomial/Factors): Introduce predicate and basic API #30212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR summary 0607ff2a96Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
(my personal opinion) I think this should be reflected in the docstring of both |
I think all of these theorems could be tagged |
I've taken a stab at this, but let me know if anything looks off (I'm not so familiar with aesop). |
Unfortunately I'm also not very familiar with aesop... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it's a personal preference but maybe you would want to move some {f : R[X]}
to variable
?
I just now realized that you are intentionally mimicking the |
This PR introduces a predicate
Polynomial.Factors
that generalizesPolynomial.Splits
beyond fields. This PR contains the definition ofPolynomial.Factors
along with most of API forPolynomial.Splits
. The end goal is to either redefinePolynomial.Splits
in terms ofPolynomial.Factors
or deprecatePolynomial.Splits
entirely.Zulip discussion: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Generalizing.20.60Polynomial.2ESplits.60.20to.20rings