Skip to content

Conversation

SnirBroshi
Copy link
Contributor

@SnirBroshi SnirBroshi commented Sep 17, 2025


Open in Gitpod

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-analysis Analysis (normed *, calculus) labels Sep 17, 2025
Copy link

github-actions bot commented Sep 17, 2025

PR summary a2df56f501

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Analysis.SpecificLimits.Fibonacci (new file) 1761

Declarations diff

+ tendsto_fib_div_fib_succ_atTop
+ tendsto_fib_succ_div_fib_atTop

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 24, 2025
@SnirBroshi
Copy link
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 2, 2025
@SnirBroshi SnirBroshi requested a review from kckennylau October 2, 2025 12:34
Copy link
Collaborator

@kckennylau kckennylau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

Copy link

github-actions bot commented Oct 3, 2025

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

…ecutive Fibonacci numbers tends to the golden ratio
@SnirBroshi SnirBroshi force-pushed the feature/fibonacci-div-limit branch from 577d84d to 8eef535 Compare October 11, 2025 16:12
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 15, 2025

✌️ SnirBroshi can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@SnirBroshi
Copy link
Contributor Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Oct 15, 2025
…ecutive Fibonacci numbers tends to the golden ratio (#29759)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/SpecificLimits/Fibonacci): prove that the ratio of consecutive Fibonacci numbers tends to the golden ratio [Merged by Bors] - feat(Analysis/SpecificLimits/Fibonacci): prove that the ratio of consecutive Fibonacci numbers tends to the golden ratio Oct 15, 2025
@mathlib-bors mathlib-bors bot closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants