-
Notifications
You must be signed in to change notification settings - Fork 839
feat(Topology/KrullDimension): add subspace dimension inequality #29728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(Topology/KrullDimension): add subspace dimension inequality #29728
Conversation
PR summary 1838dfbf5dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
If you think you have addressed all the review comments, please remove the label |
-awaiting-author |
This pull request has conflicts, please merge |
22fcd67
to
3a11cb2
Compare
-awaiting-author |
I think you have messed up something. Can you try merging master again? |
dimension inequality • Add mapIrreducibleClosed function for canonical maps between irreducible closed sets • Prove injectivity and strict monotonicity of these maps • Establish partial order structure on IrreducibleCloseds • Prove topKrullDim_subspace_le theorem showing dim(Y) ≤ dim(X) for subspaces
…nsion to Sets/Closeds Move PartialOrder instance, map functions, and embedding-related lemmas from Topology/KrullDimension.lean to Topology/Sets/Closeds.lean for better code organization. This separates basic IrreducibleCloseds operations from topological Krull dimension theory, allowing other modules to use IrreducibleCloseds functionality without importing dimension-specific concepts. Changes: - Move PartialOrder instance and le_iff_subset/lt_iff_subset lemmas to Sets/Closeds - Move IrreducibleCloseds.map and related functions for closed continuous maps - Move mapOfEmbedding functions and lemmas for general embeddings - Move mapIrreducibleClosed functions for subspace embeddings - Keep only topological Krull dimension definitions and theorems in KrullDimension - Add necessary imports to Sets/Closeds for embedding support
Co-authored-by: Johan Commelin <johan@commelin.net>
…anization Address reviewer feedback with the following improvements: - Simplify `IrreducibleCloseds.map` to work with any continuous function (no longer requires closed maps) - Rename lemmas from `mapOfEmbedding_*` to `map_*_of_embedding` for consistency with Mathlib naming conventions - Use `inferInstance` for PartialOrder instance on IrreducibleCloseds - Merge variable declarations in Sets/Closeds.lean - Add necessary imports (Topology.Defs.Induced) - Open Topology namespace for cleaner code - Simplify proofs and improve readability The main theorem `topologicalKrullDim_subspace_le` remains unchanged.
…g consistency - Simplify readability in `IrreducibleCloseds.map` making the function explicit - Rename `map_*_of_embedding` to `map_*_of_isEmbedding` for Mathlib consistency - Add `coe_map` simp lemma for cleaner proofs - Remove redundant `mapIrreducibleClosed` wrapper functions
dimension inequality • Add mapIrreducibleClosed function for canonical maps between irreducible closed sets • Prove injectivity and strict monotonicity of these maps • Establish partial order structure on IrreducibleCloseds • Prove topKrullDim_subspace_le theorem showing dim(Y) ≤ dim(X) for subspaces
8973799
to
57ef694
Compare
- Rename map_*_of_isEmbedding to map_*_of_isInducing for generality - Simplify map_injective_of_isInducing proof using SetLike.coe_injective - Simplify map_strictMono_of_isInducing using Monotone.strictMono_of_injective - Use IsInducing instead of IsEmbedding in dimension theorems - Add deprecation alias for IsClosedEmbedding.topologicalKrullDim_le - Remove redundant PartialOrder instance (already inferred)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great PR and for the patience!
maintainer delegate
🚀 Pull request has been placed on the maintainer queue by erdOne. |
I've done 'lake build Mathlib' and everything works fine in my fork. Why did the CI test fail? it seems the cache of the files I've modified is missing. |
Can you try merging master? It might be an issue about a change in CI. |
This PR extends topological Krull dimension theory with basic results about subspaces.
Update (per reviewer feedback):
Reorganized code structure as requested:
IrreducibleCloseds
extensions fromKrullDimension.lean
toSets/Closeds.lean
PartialOrder
instance,map
functions, and embedding lemmasIrreducibleCloseds
without importing Krull dimension theoryThe main result
topologicalKrullDim_subspace_le
remains the same - any subspace Y has dim(Y) ≤ dim(X).Some sections of this code (and documentation) were generated with the help of Gemini.
Update 2
Addressed reviewer feedback with the following improvements:
IrreducibleCloseds.map
to work with any continuous function(no longer requires closed maps)
mapOfEmbedding_*
tomap_*_of_isEmbedding
forconsistency with Mathlib naming conventions
inferInstance
for PartialOrder instance on IrreducibleClosedsUpdate 3
Addressed and integrated reviewer feedback:
The main theorem
topologicalKrullDim_subspace_le
remains unchanged.