Skip to content

Conversation

themathqueen
Copy link
Collaborator

@themathqueen themathqueen commented Sep 13, 2025

Generalize OrderHomClass.ofLinear from linear maps to additive group homomorphisms.


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Sep 13, 2025
Copy link

github-actions bot commented Sep 13, 2025

PR summary 02b619cd5e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.OrderHomClass.of_addMonoidHom

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@themathqueen themathqueen added the easy < 20s of review time. See the lifecycle page for guidelines. label Sep 13, 2025
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 15, 2025
@themathqueen themathqueen removed the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 15, 2025
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Oct 14, 2025
…ass.ofLinear` (#29626)

Generalize `OrderHomClass.ofLinear` from linear maps to additive group homomorphisms.
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 14, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Order/Module/PositiveLinearMap): generalize OrderHomClass.ofLinear [Merged by Bors] - chore(Algebra/Order/Module/PositiveLinearMap): generalize OrderHomClass.ofLinear Oct 14, 2025
@mathlib-bors mathlib-bors bot closed this Oct 14, 2025
@themathqueen themathqueen deleted the chore_generalize_orderhomclassoflinear branch October 14, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants