-
Notifications
You must be signed in to change notification settings - Fork 840
[Merged by Bors] - feat(CategoryTheory): functors that are dense at an object #29556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary 74170ab45eImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Will review more thoroughly later, but I really think that having "canonical" in the naming is a recipe for disaster in terms of understanding and should be avoided at all cost. I don’t believe this is standard terminology at all. Given that this is used to define dense functors, maybe I am also rather worried by the fact that the design here goes with ad hoc definitions and does not even mention (not even in docstrings!) the link with Kan extensions. The definition here is that the (left extension defined by the) inverse right unitor The ad hoc definitions here means that we’ll be having more than one way of saying the same thing, and means that depending on how many properties for dense functors we want, we may have to duplicate API etc. In fact, replacing your definition by abbrev CanonicalColimit (Y : D) : Type _ :=
(Functor.LeftExtension.mk (𝟭 D) F.rightUnitor.inv).IsPointwiseLeftKanExtensionAt Y makes the proof of Given that def canonicalCoconeIso (Y : D) :
canonicalCocone F Y ≅ (Functor.LeftExtension.mk (𝟭 D) F.rightUnitor.inv).coconeAt Y :=
Cocones.ext (.refl _) (by cat_disch) also goes through, I think it’s safe to say that we don’t lose a lot by taking Kan extensions as a definition here (and we gain the link with a well-established API). Hence I also think the file here belongs in the |
Thanks! Indeed, I should have made the connection with Kan extensions! The name "canonical colimit" is used throughout the book by Adámek and Rosický, but indeed, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
maintainer delegate
🚀 Pull request has been placed on the maintainer queue by robin-carlier. |
Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
Thanks @robin-carlier for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Given a functor `F : C ⥤ D` and `Y : D`, we say that `F` is dense at `Y` if `Y` identifies to the colimit of all `F.obj X` for `X : C` and `f : F.obj X ⟶ Y`, i.e. the obvious natural transformation makes the identity functor of `D` a pointwise left Kan extension of `F` along `F` at `Y`.
Pull request successfully merged into master. Build succeeded: |
Given a functor
F : C ⥤ D
andY : D
, we say thatF
is dense atY
ifY
identifies to the colimit of allF.obj X
forX : C
andf : F.obj X ⟶ Y
, i.e. the obvious natural transformation makes the identity functor ofD
a pointwise left Kan extension ofF
alongF
atY
.