-
Notifications
You must be signed in to change notification settings - Fork 840
[Merged by Bors] - feat(Data/Nat): define Nat.nthRoot
#28768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Data/Nat): define Nat.nthRoot
#28768
Conversation
Define `Nat.nthRoot n a` to be the `n`th root of a natural number `a`.
PR summary 4b0359cc77Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
I'll note there's a small overlap in concept here with #26935 |
AFAICT, there is no code overlap, but |
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
-awaiting-author |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golfs with grind (and making sure to replace omega
). I was surprised that fun_induction
didn't work
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
-awaiting-author |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looking forward to the norm_num extension.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by pechersky. |
Thanks! Yes it's funny that we're using real numbers to make the API for this, but if it makes life easier then why not! bors merge |
Define `Nat.nthRoot n a` to be the `n`th root of a natural number `a`.
Build failed (retrying...): |
bors r- It turns out this PR is actually failing a style lint; not sure why it isn't throwing a red x here though: https://github.com/leanprover-community/mathlib4/actions/runs/18470107241/job/52621590367#step:2:275
edit: I think I know why it didn't fire. The lint-style-action action was not updated in the branch that this PR was based off, and |
Canceled. |
bors d+ |
✌️ yury-harmonic can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
Define `Nat.nthRoot n a` to be the `n`th root of a natural number `a`.
Pull request successfully merged into master. Build succeeded: |
Nat.nthRoot
Nat.nthRoot
Define
Nat.nthRoot n a
to be then
th root of a natural numbera
.This is a dependency of a
norm_num
plugin that can handle(8 : Real) ^ (2 / 3 : Real)
.