-
Notifications
You must be signed in to change notification settings - Fork 839
feat(gcongr): support @[gcongr]
for Monotone
and friends
#28339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(gcongr): support @[gcongr]
for Monotone
and friends
#28339
Conversation
PR summary dde1cfffb6Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Thanks! |
This pull request has conflicts, please merge |
This pull request has conflicts, please merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused for a brief moment why only some lemmas got a deprecation, but the ones that were deleted outright are all in the GCongr
namespace. So that's good!
One question about the implementation strategy, otherwise the code is very neat!
This PR adds the feature to
gcongr
that you can now tag lemmas whose conclusion isMonotone f
,Antitone f
, etc.