Skip to content

Conversation

JovanGerb
Copy link
Collaborator

This PR adds the feature to gcongr that you can now tag lemmas whose conclusion is Monotone f, Antitone f, etc.


Open in Gitpod

Copy link

github-actions bot commented Aug 13, 2025

PR summary dde1cfffb6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ myAnti
+ myAnti_strictAnti
+ myAnti_strictAntiOn
+ myCons
+ myCons_antitone
+ myCons_antitoneOn
+ myCons_monotone
+ myCons_monotone'
+ myCons_monotoneOn
+ myMono
+ myMono_strictMono
+ myMono_strictMonoOn
- GCongr.algebraMap_le_algebraMap
- GCongr.algebraMap_lt_algebraMap
- GCongr.intCast_mono
- GCongr.mapDomain_mono
- GCongr.mono
- _root_.GCongr.Filter.comap_le_comap
- _root_.GCongr.Filter.map_le_map
- _root_.GCongr.coheight_le_coheight
- _root_.GCongr.height_le_height
- _root_.GCongr.natCast_le_natCast
- _root_.GCongr.natCast_lt_natCast
- ruzsaSzemerediNumberNat_le_ruzsaSzemerediNumberNat

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@kckennylau
Copy link
Collaborator

Thanks!

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 18, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 18, 2025
@grunweg grunweg added the t-meta Tactics, attributes or user commands label Aug 23, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 26, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 26, 2025
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused for a brief moment why only some lemmas got a deprecation, but the ones that were deleted outright are all in the GCongr namespace. So that's good!

One question about the implementation strategy, otherwise the code is very neat!

@Vierkantor Vierkantor added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 10, 2025
@JovanGerb JovanGerb removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants