Skip to content

feat(ModelTheory): Semilinear sets in are closed under intersection and complement #27414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

Copy link

github-actions bot commented Jul 24, 2025

PR summary 0a739db8b7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
11 files Mathlib.Algebra.SkewMonoidAlgebra.Basic Mathlib.LinearAlgebra.Basis.Basic Mathlib.LinearAlgebra.Basis.Fin Mathlib.LinearAlgebra.Basis.Flag Mathlib.LinearAlgebra.Basis.Prod Mathlib.LinearAlgebra.Basis.SMul Mathlib.LinearAlgebra.Basis.Submodule Mathlib.LinearAlgebra.FreeModule.Basic Mathlib.LinearAlgebra.LinearIndependent.Basic Mathlib.LinearAlgebra.LinearIndependent.Defs Mathlib.RingTheory.AlgebraTower
1
Mathlib.ModelTheory.Arithmetic.Presburger.Semilinear.Basic (new file) 978
Mathlib.ModelTheory.Arithmetic.Presburger.Semilinear.Nat (new file) 1210

Declarations diff

+ Finite.semilinear
+ IsPWO.exists_le_minimal
+ IsPWO.exists_minimal
+ IsPWO.exists_minimalFor
+ Linear
+ Linear.add
+ Linear.iff_eq_setOf_vadd_mulVec
+ Linear.image
+ Linear.inter
+ Linear.of_homogeneous_equation
+ Linear.preimage
+ Linear.proper_semilinear
+ Linear.semilinear
+ Linear.singleton
+ Linear.span
+ Linear.span_finset
+ Linear.univ
+ Linear.vadd
+ ProperLinear
+ ProperLinear.linear
+ ProperLinear.proper_semilinear
+ ProperSemilinear
+ ProperSemilinear.biUnion_finset
+ ProperSemilinear.empty
+ ProperSemilinear.iUnion_fintype
+ ProperSemilinear.sUnion_finset
+ ProperSemilinear.semilinear
+ ProperSemilinear.union
+ Semilinear
+ Semilinear.add
+ Semilinear.biInter_finset
+ Semilinear.biUnion_finset
+ Semilinear.compl
+ Semilinear.empty
+ Semilinear.finset
+ Semilinear.iInter_fintype
+ Semilinear.iUnion_fintype
+ Semilinear.image
+ Semilinear.inter
+ Semilinear.of_linear_equation
+ Semilinear.preimage
+ Semilinear.proj
+ Semilinear.proj'
+ Semilinear.proper_semilinear
+ Semilinear.reindex
+ Semilinear.sInter_finset
+ Semilinear.sUnion_finset
+ Semilinear.singleton
+ Semilinear.span
+ Semilinear.span_finset
+ Semilinear.union
+ Semilinear.univ
+ Semilinear.vadd
+ compl
+ linearIndepOn_finset_iffₒ
+ linearIndependent_iffₒ
+ not_linearIndepOn_finset_iffₒ
+ not_linearIndependent_iffₒ

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
818 2 erw

Current commit e38912cceb
Reference commit 0a739db8b7

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 24, 2025
@staroperator staroperator added the t-logic Logic (model theory, etc) label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-logic Logic (model theory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants