-
Notifications
You must be signed in to change notification settings - Fork 681
[Merged by Bors] - chore: generalize typeclass assumptions on DFinsupp SMul #27409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary 8b7eb3d9b2Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
!bench |
The diff itself looks good to me; I haven't compared closely to the finsupp instances. LGTM assuming benchmarking is fine! |
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Here are the benchmark results for commit 6eb9ba3. |
2 files, Instructions +6.0⬝10⁹
3 files, Instructions +5.0⬝10⁹
11 files, Instructions +4.0⬝10⁹
48 files, Instructions +3.0⬝10⁹
75 files, Instructions +2.0⬝10⁹
403 files, Instructions +1.0⬝10⁹
398 files, Instructions -2.0⬝10⁹
70 files, Instructions -3.0⬝10⁹
67 files, Instructions -4.0⬝10⁹
14 files, Instructions -5.0⬝10⁹
3 files, Instructions -6.0⬝10⁹
3 files, Instructions -7.0⬝10⁹
|
Thanks! |
These match the Finsupp instances more closely.
(I think the benchmark is probably noise, like all recent ones...) |
Pull request successfully merged into master. Build succeeded: |
…community#27409) These match the Finsupp instances more closely.
…community#27409) These match the Finsupp instances more closely.
These match the Finsupp instances more closely.