-
Notifications
You must be signed in to change notification settings - Fork 839
(WIP) Galois group of x^n - x - 1
#27053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tb65536
commented
Jul 13, 2025
PR summary dde1cfffb6Import changes exceeding 2%
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.RingTheory.Polynomial.Selmer | 2557 | 3090 | +533 (+20.84%) |
Mathlib.FieldTheory.Galois.IsGaloisGroup | 1691 | 1948 | +257 (+15.20%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.FieldTheory.Galois.IsGaloisGroup |
257 |
Mathlib.RingTheory.Polynomial.Selmer |
533 |
Declarations diff
+ AddSubgroup.subgroupOf_inertia
+ Ideal.card_inertiaSubgroup
+ Ideal.inertiaSubgroup_eq_ker
+ IsFractionRing.nontrivial'
+ IsGaloisGroup.toIsFractionRing
+ X_pow_sub_X_sub_one_gal
+ _root_.Polynomial.Monic.mem_rootSet
+ aeval_smul
+ card_fixingSubgroup_eq_finrank
+ card_subgroup_eq_finrank_fixedpoints
+ finite
+ fixedPoints_bot
+ fixedPoints_fixingSubgroup
+ fixedPoints_le_of_le
+ fixedPoints_top
+ fixingSubgroup_bot
+ fixingSubgroup_fixedPoints
+ fixingSubgroup_le_of_le
+ fixingSubgroup_top
+ genthm
+ genthm₀
+ inst4
+ instance (K : Type*) [Field K] [NumberField K]
+ instance {R S : Type*} [CommRing R] [CommRing S] [IsDomain S] [Algebra R S]
+ le_fixedPoints_iff_le_fixingSubgroup
+ switchinglemma
+ tada
+ tada'
+ tada''
+ to_intermediateField
+ to_subgroup
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
attribute [-instance] Polynomial.Gal.galActionAux -- should be local to PolynomialGaloisGroup.lean | ||
|
||
theorem X_pow_sub_X_sub_one_gal : | ||
Function.Bijective (Gal.galActionHom (X ^ n - X - 1 : ℚ[X]) ℂ) := by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: would one want to have this framed in this way or as a MulEquiv
?
-- the decomposition group acts on OK/q | ||
-- the inertia group acts trivially on OK/q | ||
-- | ||
-- there are n roots in OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same argument also works in the geometric context, for galois groups over Q(X) (see Serre Topics in Galois theory, §4.4) and I hope it will be possible to set up such a framework.