-
Notifications
You must be signed in to change notification settings - Fork 840
[Merged by Bors] - feat(LinearAlgebra/Projectivization/Subspace): correspondence between linear and projective subspaces #26909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gasparattila
commented
Jul 8, 2025
PR summary 1f467e3c77Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
07f6b7c
to
0b4cbd8
Compare
Thanks for the suggestions! I realized that the inverse is inconvenient to use, so I added an abbrev for the inverse. I also added a lemma relating the definition to the submodule of a single point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few comments, overall it looks quite nice. Do you have any further work building on this, so I can get a bit of context?
Thanks for the suggestions! The motivation for this is defining bundled projective transforms. This could be done using a class like this: class IsProjectivization K V P [Field K] [Module K V] where
equiv : P ≃ Projectivization K V Then we would have an instance -awaiting-author |
… linear and projective subspaces
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
17296d7
to
57c9cbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look at the proofs and found some tricks to make them a bit shorter and more elegant. With those changes, we should be ready to merge, thank you for all the work! 🎉
bors d+
✌️ gasparattila can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
bors r+ |
… linear and projective subspaces (#26909)
Build failed (retrying...): |
… linear and projective subspaces (#26909)
Build failed (retrying...): |
… linear and projective subspaces (#26909)
Pull request successfully merged into master. Build succeeded: |