Skip to content

Conversation

gasparattila
Copy link
Contributor


Open in Gitpod

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc) labels Jul 8, 2025
Copy link

github-actions bot commented Jul 8, 2025

PR summary 1f467e3c77

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ mem_projectivization_iff_submodule_le
+ mem_submodule_iff
+ mk_mem_projectivization_iff
+ projectivization
+ submodule

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@gasparattila
Copy link
Contributor Author

Thanks for the suggestions! I realized that the inverse is inconvenient to use, so I added an abbrev for the inverse. I also added a lemma relating the definition to the submodule of a single point.

Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments, overall it looks quite nice. Do you have any further work building on this, so I can get a bit of context?

@Vierkantor Vierkantor added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 7, 2025
@gasparattila
Copy link
Contributor Author

gasparattila commented Oct 7, 2025

Thanks for the suggestions! The motivation for this is defining bundled projective transforms. This could be done using a class like this:

class IsProjectivization K V P [Field K] [Module K V] where
  equiv : P ≃ Projectivization K V

Then we would have an instance IsProjectivization K s.submodule s for s : Projectivization.Subspace K V to allow defining maps between subspaces. But I'm not sure if this is the best design and I'm currently not planning to work on this.

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 7, 2025
gasparattila and others added 3 commits October 7, 2025 19:13
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at the proofs and found some tricks to make them a bit shorter and more elegant. With those changes, we should be ready to merge, thank you for all the work! 🎉

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 15, 2025

✌️ gasparattila can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@gasparattila
Copy link
Contributor Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Oct 16, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 16, 2025

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Oct 16, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 16, 2025

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Oct 16, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 16, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(LinearAlgebra/Projectivization/Subspace): correspondence between linear and projective subspaces [Merged by Bors] - feat(LinearAlgebra/Projectivization/Subspace): correspondence between linear and projective subspaces Oct 16, 2025
@mathlib-bors mathlib-bors bot closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants