-
Notifications
You must be signed in to change notification settings - Fork 839
[Merged by Bors] - feat: norm_num support for Int.fract #26428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: norm_num support for Int.fract #26428
Conversation
Ruben-VandeVelde
commented
Jun 26, 2025
PR summary 39996ca4dbImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com>
@Rob23oba Thanks for the comments you left already! Do you have any more, or are you (from your side) happy with this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
bors d+
Mathlib/Data/Rat/Floor.lean
Outdated
example : Int.fract (3.7 : ℚ) = 0.7 := by norm_num | ||
example : Int.fract (-3.7 : ℚ) = 0.3 := by norm_num |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Could you write a comment explaining) why did some examples end up in this file and some in the test folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume they are fine to move to the test file.
✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with |
Thanks! bors r+ |
Pull request successfully merged into master. Build succeeded: |