Skip to content

Conversation

Ruben-VandeVelde
Copy link
Collaborator


Open in Gitpod

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Jun 26, 2025
Copy link

github-actions bot commented Jun 26, 2025

PR summary 39996ca4db

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ evalIntFract
+ isNNRat_intFract_of_isNNRat
+ isNat_intFract_of_isInt
+ isNat_intFract_of_isNat
+ isRat_intFract_of_isRat_negOfNat

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Ruben-VandeVelde and others added 2 commits June 26, 2025 23:22
Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com>
@Ruben-VandeVelde Ruben-VandeVelde marked this pull request as ready for review June 26, 2025 21:26
@grunweg grunweg assigned Rob23oba and unassigned ericrbg Aug 21, 2025
@grunweg
Copy link
Collaborator

grunweg commented Aug 21, 2025

@Rob23oba Thanks for the comments you left already! Do you have any more, or are you (from your side) happy with this PR?

@grunweg grunweg added the t-meta Tactics, attributes or user commands label Aug 21, 2025
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

bors d+

Comment on lines 285 to 286
example : Int.fract (3.7 : ℚ) = 0.7 := by norm_num
example : Int.fract (-3.7 : ℚ) = 0.3 := by norm_num
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Could you write a comment explaining) why did some examples end up in this file and some in the test folder?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume they are fine to move to the test file.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 7, 2025

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Oct 7, 2025
@Ruben-VandeVelde
Copy link
Collaborator Author

Thanks!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Oct 20, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 20, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: norm_num support for Int.fract [Merged by Bors] - feat: norm_num support for Int.fract Oct 20, 2025
@mathlib-bors mathlib-bors bot closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-data Data (lists, quotients, numbers, etc) t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants