[Merged by Bors] - feat(NumberTheory/Cyclotomic/Basic): any cyclotomic extension is abelian #26427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmepjz
added
t-algebra
acmepjz
changed the title
github-actions
bot
added
the
t-number-theory
PR summary c873c5d1d1Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
What's wrong with |
See zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Failing.20CI |
github-actions
bot
removed
the
awaiting-CI
|
✌️ acmepjz can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
the
delegated
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 30, 2025
…ian (#26427) Proved `IsCyclotomicExtension.isMulCommutative` that any cyclotomic extension (of rings) is abelian. Deprecated `IsCyclotomicExtension.Aut.commGroup` which is `CommGroup` and only adjoins one root of unity. Now `CommGroup` instance should be inferred automatically if `IsMulCommutative` is provided (the preferred spelling of abelian extension, see #23669 (comment)).
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 30, 2025
…ian (#26427) Proved `IsCyclotomicExtension.isMulCommutative` that any cyclotomic extension (of rings) is abelian. Deprecated `IsCyclotomicExtension.Aut.commGroup` which is `CommGroup` and only adjoins one root of unity. Now `CommGroup` instance should be inferred automatically if `IsMulCommutative` is provided (the preferred spelling of abelian extension, see #23669 (comment)).
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Jul 7, 2025
…ian (leanprover-community#26427) Proved `IsCyclotomicExtension.isMulCommutative` that any cyclotomic extension (of rings) is abelian. Deprecated `IsCyclotomicExtension.Aut.commGroup` which is `CommGroup` and only adjoins one root of unity. Now `CommGroup` instance should be inferred automatically if `IsMulCommutative` is provided (the preferred spelling of abelian extension, see leanprover-community#23669 (comment)).
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
…ian (leanprover-community#26427) Proved `IsCyclotomicExtension.isMulCommutative` that any cyclotomic extension (of rings) is abelian. Deprecated `IsCyclotomicExtension.Aut.commGroup` which is `CommGroup` and only adjoins one root of unity. Now `CommGroup` instance should be inferred automatically if `IsMulCommutative` is provided (the preferred spelling of abelian extension, see leanprover-community#23669 (comment)).
hrmacbeth
pushed a commit
to szqzs/mathlib4
that referenced
this pull request
Jul 28, 2025
…ian (leanprover-community#26427) Proved `IsCyclotomicExtension.isMulCommutative` that any cyclotomic extension (of rings) is abelian. Deprecated `IsCyclotomicExtension.Aut.commGroup` which is `CommGroup` and only adjoins one root of unity. Now `CommGroup` instance should be inferred automatically if `IsMulCommutative` is provided (the preferred spelling of abelian extension, see leanprover-community#23669 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proved
IsCyclotomicExtension.isMulCommutativethat any cyclotomic extension (of rings) is abelian.Deprecated
IsCyclotomicExtension.Aut.commGroupwhich isCommGroupand only adjoins one root of unity. NowCommGroupinstance should be inferred automatically ifIsMulCommutativeis provided (the preferred spelling of abelian extension, see #23669 (comment)).