Support Swift 6 #277
Merged
Support Swift 6 #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heoblitz
commented
Jul 20, 2025
| name: "FlexLayout", | ||
| platforms: [ | ||
| .iOS(.v12), | ||
| .iOS(.v13), |
There was a problem hiding this comment.
The minimum supported version has been raised to enable the use of MainActor.
For CocoaPods, the current minimum supported version is iOS 13.4.
|
|
||
| import UIKit | ||
|
|
||
| @MainActor |
There was a problem hiding this comment.
Since the flex property of UIView is isolated to the MainActor, the corresponding global variable is also annotated with MainActor instead of nonisolated.
|
|
||
| final class InsetTests: XCTestCase { | ||
| @MainActor | ||
| final class InsetTests: XCTestCase, Sendable { |
There was a problem hiding this comment.
Modify to allow testing of MainActor-isolated objects.
| label.flex.margin(10) | ||
| ``` | ||
| */ | ||
| @MainActor |
There was a problem hiding this comment.
Flex creates and manages UIViews, so it should also use MainActor.
lucdion
approved these changes
Jul 21, 2025
|
It seems I don’t have permission to merge into master, so please merge when you have time. Thank you. |
|
Thanks, its merged and a new release 2.2.2 is published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR?
Many major libraries support building in the Swift 6 environment. FlexLayout has also been updated to build with Swift 6.
Related to #276