feat: Add option to enable compression of event payloads #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
reviewed
Dec 4, 2024
| @@ -5,7 +5,7 @@ cabal-version: 1.12 | |||
| -- see: https://github.com/sol/hpack | |||
|
|
|||
| name: launchdarkly-server-sdk | |||
| version: 4.2.0 | |||
| version: 4.3.0 | |||
There was a problem hiding this comment.
I am a little confused about the version number being out of date?
There was a problem hiding this comment.
A deficiency of the build system I need to fix.
kinyoklion
reviewed
Dec 4, 2024
| @@ -69,12 +74,15 @@ eventThread manager client clientContext = do | |||
| payloadId <- liftIO $ atomicModifyIORef' rngRef (swap . random) | |||
| let | |||
| encoded = encode events' | |||
| compressed = if compressEvents then GZip.compress encoded else encoded | |||
There was a problem hiding this comment.
Should it maybe be something like maybeCompressed? Or alternatively more generic like payload.
kinyoklion
approved these changes
Dec 4, 2024
keelerm84
added a commit
that referenced
this pull request
Dec 6, 2024
🤖 I have created a release *beep* *boop* --- ## [4.4.0](4.3.0...4.4.0) (2024-12-05) This release introduces the ability to enable compression of event payloads. When enabled, the SDK will compress events before sending them to the LaunchDarkly servers. This can reduce the bandwidth required to send events, which can be useful in high-traffic environments to reduce egress traffic costs. > [!IMPORTANT] > Relay Proxy users **MUST** upgrade to version 8.9 or higher prior to enabling this option to prevent loss of event data. > > However, enabling this feature is **NOT** required when using the Relay Proxy as it will manage compression automatically. ### Features * Add option to enable compression of event payloads ([#91](#91)) ([cb21081](cb21081)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Keeler <mkeeler@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.