Further reduce dependency on futures and futures-util
#3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolobarbolini
force-pushed
the
more-less-futures-util
branch
2 times, most recently
from
e90c61b to
6846087
Compare
paolobarbolini
changed the title
futures and futures-util
paolobarbolini
force-pushed
the
more-less-futures-util
branch
from
6846087 to
d78d453
Compare
svix-jplatte
approved these changes
May 25, 2025
abonander
reviewed
May 26, 2025
| @@ -103,7 +103,7 @@ impl<'a, T> Stream for TryAsyncStream<'a, T> { | |||
| return Poll::Ready(None); | |||
| } | |||
|
|
|||
| match self.future.poll_unpin(cx) { | |||
| match Pin::new(&mut self.future).poll(cx) { | |||
There was a problem hiding this comment.
Preliminary comment: I feel like this is actually a small net-negative to code readability. If there is a real improvement in compile- or run-time performance to getting rid of FutureExt here, I would almost prefer if we created our own FutureExt trait to stick actually-useful methods on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3721
Is this a breaking change?
No