Disallowed create users if feature is disabled #1557
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are rebuilding our starter kits now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that removing
Features::registration()fromconfig/fortify.phpstill allows external users to create accounts.I'm not sure if is a bug related to fortify (the repo seems to be fine), but is very hard to go deeper with this quantity of dependencies.
Anyways, this behavior must be controlled by the final application, just like these cases that the feature removal is not working (you can just access to /register and create an account).
The website I'm creating (and for sure, a lot of websites created with laravel) must disable the registration.
So this is more a workaround than a true fix, but I don't know how to fix it correctly, additional supoprt would be welcome.