Improve job serialization error message with job class name #56398
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error message when a queued job fails to serialize (usually due to Closure or resource property).
Instead of the generic
Serialization of 'Closure' is not allowed, this will show which job caused the error.In large projects with many jobs, debugging such errors becomes very time-consuming.
This small improvement helps identify the problematic job instantly.
This PR does not break anything. It only adds a try/catch around serialize(...) to enrich the error message.
Before
'Serialization of 'Closure' is not allowed'
After
'Failed to serialize job of type [App\Jobs\UpdateSomething]: Serialization of 'Closure' is not allowed'