feat: wrap_gemini beta python #2059
Open
+765
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacoblee93
reviewed
Oct 8, 2025
|
|
||
| .. code-block:: python | ||
|
|
||
| from google import genai |
There was a problem hiding this comment.
I know they have a bunch of different clients and they were unifying them - but is it worth calling this wrap_google_genai instead?
Think it's also better because I'm pretty sure you can access non-Gemini models (e.g. Gemma, other Model Garden stuff)
|
|
||
| # Non-streaming: | ||
| response = client.models.generate_content( | ||
| model="gemini-2.0-flash-001", |
There was a problem hiding this comment.
nit: use latest model string
| return {k: v for k, v in d.items() if v is not None} | ||
|
|
||
|
|
||
| def _process_gemini_inputs(inputs: dict) -> dict: |
There was a problem hiding this comment.
Any special consideration needed for tool calls?
There was a problem hiding this comment.
Would definitely add a tool calling test too
jacoblee93
reviewed
Oct 8, 2025
| stop = config.get("stop_sequences") | ||
|
|
||
| return { | ||
| "ls_provider": "google", |
There was a problem hiding this comment.
Worth checking to make sure this is the same as LangChain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap_gemini has been requested quite many times (23 upvotes from sdk issues); we wanted to make it in September
Tests: integration test (still need to add google_api_key in github settings) and inspection in langsmith https://smith.langchain.com/public/d3958002-41cd-4df2-9711-91689ec3ea88/r
Note: mark as beta because even though the messages goes up to langsmith, i expect there'll be edges cases on rendering we need to take care of; don't really expect much breaking changes but wanna be proactive in setting expectation