feat: add log of base_url #2058
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for event in [*data.get("post", []), *data.get("patch", [])]: | ||
| metadata = event.get("extra", {}).get("metadata", {}) | ||
| if base_url := metadata.get("openai_base_url"): | ||
| assert "api.openai.com" in base_url |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 7 days ago
To fix the problem, the code should extract the host part from base_url using urllib.parse.urlparse, then check if the hostname matches or ends with the expected domain. This ensures malicious domains such as "evil-api.openai.com.attacker.com" do not get accepted, and prevents accidental substring matches in arbitrary positions.
Specifically:
- Import
urllib.parse.urlparse. - Replace the substring check
if "api.openai.com" in base_url:with logic that parsesbase_urland checks if thehostnameis exactly"api.openai.com"(or, if subdomains are desired, ends with.api.openai.com). Since the original code wants to check for presence of"api.openai.com", matching exactly is the clearest option.
Required changes:
- Add the import line.
- Change the assertion block so that
base_urlis parsed viaurlparse, and then the hostname property is tested accordingly.
Suggested changeset
1
python/tests/integration_tests/wrappers/test_openai.py
| @@ -840,7 +840,8 @@ | ||
| for event in [*data.get("post", []), *data.get("patch", [])]: | ||
| metadata = event.get("extra", {}).get("metadata", {}) | ||
| if base_url := metadata.get("openai_base_url"): | ||
| assert "api.openai.com" in base_url | ||
| from urllib.parse import urlparse | ||
| assert urlparse(base_url).hostname == "api.openai.com" | ||
| return | ||
|
|
||
| raise AssertionError("openai_base_url not found in metadata") |
Copilot is powered by AI and may make mistakes. Always verify output.
jacoblee93
reviewed
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worth adding this openai.base_url since it's important metadata, helping usage analytics of openAI format-compliant providers such as gemini
idea credits to jake https://langchain.slack.com/archives/C08RJTF3QS2/p1758664251472349?thread_ts=1758663268.667749&cid=C08RJTF3QS2