chore(python): Prefer provided project_name to environment in tracing context #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
commented
Aug 20, 2025
| _get_parent_run( | ||
| { | ||
| "parent": parent or kwargs.get("parent_run"), | ||
| "project_name": project_name, |
There was a problem hiding this comment.
This is the change here.
hinthornw
commented
Aug 20, 2025
| assert not mock_calls | ||
|
|
||
|
|
||
| def test_set_parent_and_project_name(): |
hinthornw
force-pushed
the
wfh/set_project
branch
from
25eeb12 to
5881ab9
Compare
jacoblee93
reviewed
Aug 20, 2025
| enable-cache: true | ||
| - name: Build project for distribution | ||
| run: cd python && uv build | ||
| - name: Check Version |
There was a problem hiding this comment.
because i switched to dynamic version
jacoblee93
reviewed
Aug 20, 2025
| return [ | ||
| ( | ||
| datetime.strptime(part[:-TIMESTAMP_LENGTH], "%Y%m%dT%H%M%S%fZ"), | ||
| datetime.strptime(part[:-TIMESTAMP_LENGTH], "%Y%m%dT%H%M%S%fZ").replace( |
There was a problem hiding this comment.
This makes me slightly nervous
There was a problem hiding this comment.
can remove if you want. we were just ignoring anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a dotted_order style parent, the provided project_name wasn't being applied to that constructed run tree.
Also updated lockfile which seems to have given the formatter a field day.