-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(langgraph): optimize interrupt task scheduling #6254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
casparb
wants to merge
23
commits into
main
Choose a base branch
from
caspar/interrupt_scheduling_optimization_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+686
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt_with_send_payloads_sequential_resume_async
…ould not execute until both have been resumed
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
The original PR was reverted in #6252 because it was breaking CI in langgraph-api due to a bug where invoking an interrupted graph with None would cause duplicate interrupt writes to appear in the task. This has been fixed and a test has been added to verify this:
test_invoke_interrupted_graph_with_none
Description
Prevents interrupt tasks from executing when the resume value has not yet been specified.
Implemented for sync and async Pregel loop
If a task execution is skipped, the skipped interrupt is still included in the graph result for consistency:
Tests
test_interrupt_with_send_payloads
: test for a single resume map that resumes all interrupts at oncetest_interrupt_with_send_payloads_sequential_resume
: test for two resume maps delivered in sequencetest_node_with_multiple_interrupts_requires_full_resume
test optimization for multiple interrupts within a single nodeSolves #6208