Fix incorrect escape sequence in regular expression in base.py.
#6234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
eyurtsev
reviewed
Oct 2, 2025
| FROM ( | ||
| SELECT part, ROW_NUMBER() OVER () AS idx | ||
| FROM UNNEST(REGEXP_SPLIT_TO_ARRAY(prefix, '\.')) AS part | ||
| FROM UNNEST(REGEXP_SPLIT_TO_ARRAY(prefix, '\\.')) AS part |
There was a problem hiding this comment.
could you include a test? that shows that this fails?
There was a problem hiding this comment.
there is no test failing, it was giving warning in logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(checkpoint-postgres): correct escape sequence in Postgres regex split
Description
Fixes an incorrect escape sequence in the
REGEXP_SPLIT_TO_ARRAYcall used to parse namespace prefixes inlibs/checkpoint-postgres/langgraph/store/postgres/base.py.The regex now uses a properly escaped dot (
'\\.') so that splitting occurs only on literal periods rather than any character, ensuring accurate namespace aggregation in_get_batch_list_namespaces_queries.Issue
N/A (no linked issue).
Dependencies
None
Notes
'\.'to'\\.'inside SQL string literal to prevent unintended splitting behavior.