fix: generic type args should be serialized for de-serialization, clo… #6103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(checkpoint): generic type args should be serialized for de-serialization
PR message*:
GenericModel[AnotherModel]
from the module, this only work if the specialized type is defined at top level of a module, I assume it is pydantic's behaviour to add identifierGenericModel[AnotherModel]
to module after calling a generic pydantic model's__class_getitem__
method.The fix code will write all generic type arguments into graph and then create these types on de-serialization.
It is compatible with data serialized by the original code and maintains the same behavior as the original code (returning a dict). closing #6102.
tests.test_jsonplus.test_serde_jsonplus_with_pydantic_generic