fix(infra): harden pydantic test workflow against command injection #33446
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the pydantic-version input into an environment variable instead of directly interpolating it into the bash command, following GitHub Actions security best practices. While this workflow is only callable by maintainers (limiting practical risk), using environment variables for inputs is the recommended security pattern and helps prevent potential issues if the workflow structure changes in the future.
ColeMurray
requested review from
baskaryan,
ccurme and
eyurtsev
as code owners
github-actions
bot
added
infra
ColeMurray
changed the title
github-actions
bot
added
fix
and removed
fix
infra
github-actions
bot
added
infra
eyurtsev
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the pydantic-version input into an environment variable instead of directly interpolating it into the bash command, following GitHub Actions security best practices.
While this workflow is only callable by maintainers (limiting practical risk), using environment variables for inputs is the recommended security pattern and helps prevent potential issues if the workflow structure changes in the future.